tree d9f460e85bfa57838f0fd77ae978218072a7441d
parent 49f714e11508237fec456345a90d7ebca354362f
author Octavian Purdila <tavip@google.com> 1744057447 -0700
committer Chenglong Tang <chenglongtang@google.com> 1747778188 -0700

net_sched: sch_sfq: use a temporary work area for validating configuration

[ Upstream commit 8c0cea59d40cf6dd13c2950437631dd614fbade6 ]

Many configuration parameters have influence on others (e.g. divisor
-> flows -> limit, depth -> limit) and so it is difficult to correctly
do all of the validation before applying the configuration. And if a
validation error is detected late it is difficult to roll back a
partially applied configuration.

To avoid these issues use a temporary work area to update and validate
the configuration and only then apply the configuration to the
internal state.

BUG=b/413632768
TEST=presubmit
RELEASE_NOTE=None

cos-patch: security-high
Change-Id: I59571be463b36d88df43a6a4a1e3f890faef6a41
Signed-off-by: Octavian Purdila <tavip@google.com>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Stable-dep-of: b3bf8f63e617 ("net_sched: sch_sfq: move the limit validation")
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: chenglongtang <chenglongtang@google.com>
Reviewed-on: https://cos-review.googlesource.com/c/third_party/kernel/+/102621
Tested-by: Cusky Presubmit Bot <presubmit@cos-infra-prod.iam.gserviceaccount.com>
Reviewed-by: Shuo Yang <gshuoy@google.com>